Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Web Search Functionality #185

Merged
merged 13 commits into from
Aug 29, 2021
Merged

[FEATURE] Web Search Functionality #185

merged 13 commits into from
Aug 29, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Aug 28, 2021 •
edited by pull-request-badge bot
Loading

Lissy93 /FEATURE/web-search → Lissy93/dashy Commits: 13 | Files Changed: 12 | Additions: 274 Powered by Pull Request Badge

Category: Feature

Overview
Adds option for user to search the web using the search field. With support for multiple search engines, including custom or self-hosted instances. Plus configurable launching methods (newtab, sametab, workspace).

Issue Number #180

New Vars
appConfig.webSearch - Object, Optionsl

Field Type Required Description
disableWebSearch string Optional Web search is enabled by default, but can be disabled by setting this property to true
searchEngine string Optional Set the key name for your search engine. Can also use a custom engine by setting this property to custom. Currently supported: duckduckgo, google, whoogle, qwant, startpage, searx-bar and searx-info. Defaults to duckduckgo
customSearchEngine string Optional You can also use a custom search engine, or your own self-hosted instance. This requires searchEngine: custom to be set. Then add the URL of your service, with GET query string included here
openingMethod string Optional Set your preferred opening method for search results: newtab, sametab, workspace. Defaults to newtab

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Aug 28, 2021 •
edited
Loading

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: f043d66

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/612b9ecb6d7abb0007a9c0c9

😎 Browse the preview: https://deploy-preview-185--dashy-dev.netlify.app

@viezly
Copy link

viezly bot commented Aug 28, 2021 •
edited
Loading

Changes preview:

👀 Review pull request on Viezly

@Lissy93 Lissy93 merged commit 56272e5 into master Aug 29, 2021
@Lissy93 Lissy93 deleted the FEATURE/web-search branch August 29, 2021 14:51
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
@walkxcode
🍱 Adds Memos (Lissy93#185)
04bb156 
Closes Lissy93#185

Signed-off-by: Bjorn Lammers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lissy93 @EVOTk